Fix Messaging interface and MessagingStatic's ios property #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1400 1400
Misses 438 438 |
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1400 1400
Misses 438 438 |
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1400 1400
Misses 438 438 |
Salakar
approved these changes
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to documentation here and js implementation here,
iosis a property ofMessaginginstance, not a static property ofMessagingclass. However, the current typescript typing is wrong, whereiosis a static property not instance property ofMessaging.Checklist
AndroidiOSe2etests added or updated in /tests/e2e/*Test Plan
Release Plan
[TYPES][BUGFIX] [MESSAGING] - Fix Messaging interface and MessagingStatic's ios property bug